feat: add instance stats to version check #3835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sighphyre
reviewed
May 23, 2023
src/lib/services/version-service.ts
Outdated
| @@ -23,11 +26,20 @@ export interface IVersionResponse { | |||
| latest: boolean; | |||
| } | |||
|
|
|||
| export interface IFeatureUsageInfo extends InstanceStats { | |||
There was a problem hiding this comment.
My gut feels is that IFeatureUsageInfo is a sub interface of InstanceStats by coincidence rather than a thing that should always be true. We may very well choose to change both these data blobs in ways that make the other one sad. I would just create a new interface here with the same fields
There was a problem hiding this comment.
Yeah good point! thanks!
daveleek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Adds feature usage info and custom strategy counters to the version check object.
Closes #
Important files
Discussion points