chore: lower log-level for unexpected errors

[thomasheartman]

This change lowers the log level from warning to debug for when we see unexpected error types.

Right now this triggers for Joi errors, which we still rely on pretty heavily. Lowering this should clear up logs for most users.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments

Name	Status	Preview	Updated (UTC)
unleash-docs	⬜️ Ignored (Inspect)		May 23, 2023 7:26am
unleash-monorepo-frontend	⬜️ Ignored (Inspect)		May 23, 2023 7:26am

[sjaanus]

I wonder if we might miss some important errors, because this seems global.

[thomasheartman]

Good question. So this is global, but there's a few things to consider:

1. This only tells us if the error wasn't spawned by one of our custom error types. With the exception of Joi validation errors and unexpected server errors (type errors, null errors, etc), they all should be. This was primarily put in place to discover cases like Joi.
2. On line 40 of the same file, we log the error's message with a warn-level regardless. So the error won't disappear from the logs. You'll just not get the big "it was something we didn't expect" message.

Does that make sense?

[thomasheartman]

@sjaanus Just wanted to remind you of this one now that we're back from Poland. Any more thoughts on this?

[sjaanus]

LG