fix: Only show names as changed when titles have changed. #3843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Tymek
approved these changes
May 23, 2023
frontend/src/component/changeRequest/ChangeRequest/StrategyTooltipLink/StrategyTooltipLink.tsx
Outdated
Show resolved
Hide resolved
|
Discussion point: if you give a strategy a title that matches its display name: should it be shown as a change? I think "yes", but I'm happy to hear otherwise. It currently does do that:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to linear task 1-954.
This PR changes the display logic for showing titles as changed: it previously fell back to always being
trueif there was a custom title set for a strategy. This PR makes it so that it only shows as changed if the title has actually changed, either from one custom title to another, or to and from the display name.To accommodate the last bit, it also shows display names with a strikethrough if the strategy had no title previously, but now it does.
Here's a number of different examples: