fix: move application logic to service #3846
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
|
||
| const env = feature.environments.find((e) => e.name === environment); | ||
| const hasOnlyDisabledStrategies = env!.strategies.every( |
There was a problem hiding this comment.
the ! to ignore type system in production code is not a good idea. I replaced it with env?. because I managed to get null pointer here
| { environment, projectId, featureName }, | ||
| userName, | ||
| req.user, | ||
| const updatedStrategy = await this.startTransaction(async (tx) => |
There was a problem hiding this comment.
updating strategy and toggle should be part of one DB transaction
| @@ -510,6 +510,29 @@ class FeatureToggleService { | |||
| return this.unprotectedUpdateStrategy(id, updates, context, userName); | |||
| } | |||
|
|
|||
| async optionallyDisableFeature( | |||
There was a problem hiding this comment.
this was previously in a controller but it means that change requests calling service methods don't have access to full functionality. Overall controller shouldn't orchestrate application logic, application service should do it.
| @@ -180,7 +183,7 @@ const createTestSegments = async () => { | |||
|
|
|||
| beforeAll(async () => { | |||
| db = await dbInit('segments', getLogger); | |||
| app = await setupApp(db.stores); | |||
| app = await setupAppWithCustomConfig(db.stores, {}, db.rawDatabase); | |||
There was a problem hiding this comment.
we need to pass raw database because otherwise transactions don't work in this test
| ); | ||
| } | ||
| } | ||
|
|
||
| async unprotectedUpdateStrategy( |
There was a problem hiding this comment.
this method is called by change requests apply method
About the changes
Fixing problem that manifested in change requests application but the root cause was in the toggle controller:
Important files
Discussion points