feat: add usage of segment in list #3853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sjaanus
commented
May 24, 2023
sjaanus
commented
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kwasniew
requested changes
May 24, 2023
| @@ -402,6 +402,8 @@ export interface ISegment { | |||
| description?: string; | |||
| project?: string; | |||
| constraints: IConstraint[]; | |||
| usedInProjects?: number; | |||
There was a problem hiding this comment.
does it have to be optional? Is there any scenario where we don't know the number?
There was a problem hiding this comment.
Yes, only case when we know the number is the when we load the list. Throughout app, other places, we dont know it about segment
src/lib/db/segment-store.ts
Outdated
| @@ -97,8 +99,29 @@ export default class SegmentStore implements ISegmentStore { | |||
|
|
|||
| async getAll(): Promise<ISegment[]> { | |||
| const rows: ISegmentRow[] = await this.db | |||
| .select(this.prefixColumns()) | |||
| .select( | |||
There was a problem hiding this comment.
do we have any backend test that will tell us when this query breaks?
kwasniew
approved these changes
May 24, 2023
sjaanus
commented
May 26, 2023
| @@ -56,6 +65,10 @@ export const SegmentTable = () => { | |||
| return segments; | |||
| }, [segments, projectId]); | |||
|
|
|||
| const columns = useMemo( | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.