feat: maintenance mode disables scheduler #3854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
kwasniew
commented
May 24, 2023
|
|
||
| return logger; | ||
| return { logger, getRecords }; |
There was a problem hiding this comment.
changing structure to fix TS errors
kwasniew
commented
May 24, 2023
| const schedulerService = new SchedulerService(logger); | ||
| const job = jest.fn(); | ||
|
|
||
| schedulerService.pause(); |
There was a problem hiding this comment.
pause will prevent immediate run and scheduled run
kwasniew
commented
May 24, 2023
| constructor( | ||
| { | ||
| patStore, | ||
| eventStore, | ||
| }: Pick<IUnleashStores, 'patStore' | 'eventStore'>, | ||
| config: IUnleashConfig, | ||
| settingService: SettingService, | ||
| schedulerService: SchedulerService, |
There was a problem hiding this comment.
new explicit dependency so that maintenance mode can affect the scheduler
kwasniew
commented
May 24, 2023
| @@ -51,6 +56,11 @@ export default class MaintenanceService { | |||
| setting: MaintenanceSchema, | |||
| user: string, | |||
| ): Promise<void> { | |||
| if (setting.enabled) { | |||
There was a problem hiding this comment.
this is the core of the logic for the runtime behavior
kwasniew
commented
May 24, 2023
| } = services; | ||
|
|
||
| if (await maintenanceService.isMaintenanceMode()) { |
There was a problem hiding this comment.
this is the core of the logic for the startup behavior
kwasniew
commented
May 24, 2023
| @@ -43,7 +43,7 @@ async function createApp( | |||
| const db = createDb(config); | |||
| const stores = createStores(config, db); | |||
| const services = createServices(stores, config, db); | |||
| scheduleServices(services); | |||
| await scheduleServices(services); | |||
There was a problem hiding this comment.
waiting on maintenance mode telling us if it's on/off
kwasniew
commented
May 24, 2023
| @@ -1,12 +1,17 @@ | |||
| import { Logger, LogProvider } from '../logger'; | |||
|
|
|||
| export type SchedulerMode = 'active' | 'paused'; | |||
There was a problem hiding this comment.
scheduler can be in paused mode now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Important files
Discussion points