Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: profile should wait for loaded state before rendering #3855

Merged
merged 1 commit into from
May 24, 2023

Conversation

nunogois
Copy link
Member

Small change that makes it so that the profile page waits for the loaded state before rendering.

E.g. Before this, there was a flash of the "change password" tab being visible for a very short time before the auth settings loaded.

@vercel
Copy link

vercel bot commented May 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview May 24, 2023 10:26am
1 Ignored Deployment
Name Status Preview Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) May 24, 2023 10:26am

@nunogois nunogois enabled auto-merge (squash) May 24, 2023 10:26
Copy link
Contributor

@gardleopard gardleopard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@gardleopard gardleopard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nunogois nunogois merged commit ea057c0 into main May 24, 2023
17 checks passed
@nunogois nunogois deleted the fix-improve-profile-loading branch May 24, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants