Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: laggy toggles #3873

Merged
merged 3 commits into from
May 26, 2023
Merged

Fix: laggy toggles #3873

merged 3 commits into from
May 26, 2023

Conversation

andreas-unleash
Copy link
Contributor

This PR removes the disabled state for the feature toggle env switches.

This is what causes the lag from when you toggle the switch to when it becomes available for actions again.

About the changes

Closes #

Important files

Discussion points

Signed-off-by: andreas-unleash <andreas@getunleash.ai>
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
@vercel
Copy link

vercel bot commented May 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 26, 2023 1:49pm
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 26, 2023 1:49pm

Copy link
Contributor

@gastonfournier gastonfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG! Let's test it out!

@gastonfournier gastonfournier merged commit 89df3f3 into main May 26, 2023
18 checks passed
@gastonfournier gastonfournier deleted the fix/laggy_toggles branch May 26, 2023 14:42
gastonfournier pushed a commit that referenced this pull request May 26, 2023
This PR removes the `disabled` state for the feature toggle env
switches.

This is what causes the lag from when you toggle the switch to when it
becomes available for actions again.


Signed-off-by: andreas-unleash <andreas@getunleash.ai>
Co-authored-by: Nuno Góis <github@nunogois.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants