security: Reject multiple successive slashes in path #3880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
chriswk
commented
May 27, 2023
Comment on lines
+48
to
+59
| test(`Access with API token is granted`, async () => { | ||
| let token = await app.services.apiTokenService.createApiTokenWithProjects({ | ||
| environment: 'default', | ||
| projects: ['default'], | ||
| tokenName: 'test', | ||
| type: ApiTokenType.CLIENT, | ||
| }); | ||
| await app.request | ||
| .get('/api/client/features') | ||
| .set('Authorization', token.secret) | ||
| .expect(200); | ||
| }); |
There was a problem hiding this comment.
I know we're testing this already, so this test could probably be removed.
ivarconr
approved these changes
May 27, 2023
chriswk
force-pushed
the
task/refuseMultipleSuccessiveSlashesInPath
branch
from
5a7d8bd
to
a837989
Compare
chriswk
pushed a commit
that referenced
this pull request
May 27, 2023
chriswk
pushed a commit
that referenced
this pull request
May 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.