Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reject unauthorized client requests #3881

Merged
merged 1 commit into from
May 27, 2023

Conversation

chriswk
Copy link
Contributor

@chriswk chriswk commented May 27, 2023

If apiTokens are enabled breaks middleware chain with a 401 if no token is found for requests to client and frontend apis. Previously the middleware allowed the chain to process.

Removes the regex search for multiple slashes, and instead configures the apiTokenMiddleware to reject unauthorized requests.

If apiTokens are enabled breaks middleware chain with a 401 if no token
is found for requests to client and frontend apis. Previously the
middleware allowed the chain to process.
@chriswk chriswk requested a review from ivarconr May 27, 2023 14:20
@vercel
Copy link

vercel bot commented May 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) May 27, 2023 2:20pm
unleash-monorepo-frontend ⬜️ Ignored (Inspect) May 27, 2023 2:20pm

@chriswk chriswk merged commit 52904ee into main May 27, 2023
12 checks passed
@chriswk chriswk deleted the fix/rejectClientApiFrontendApi branch May 27, 2023 14:29
chriswk pushed a commit that referenced this pull request May 27, 2023
If apiTokens are enabled breaks middleware chain with a 401 if no token
is found for requests to client and frontend apis. Previously the
middleware allowed the chain to process.

Removes the regex search for multiple slashes, and instead configures
the apiTokenMiddleware to reject unauthorized requests.
chriswk pushed a commit that referenced this pull request May 27, 2023
If apiTokens are enabled breaks middleware chain with a 401 if no token
is found for requests to client and frontend apis. Previously the
middleware allowed the chain to process.

Removes the regex search for multiple slashes, and instead configures
the apiTokenMiddleware to reject unauthorized requests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants