-
-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: simplify workflows #3902
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the change, but I still have to ask if this really lowers cognitive load?
Now we have to parse a more complicated workflow file, and pay attention to the step ids to know what's going on.
Still a 👍, because I do most heartily agree that we have too many workflows going on.
@chriswk I was also concerned about the cognitive load when adding two conditional steps. I dig a bit further and came up with some changes using something similar to https://github.com/docker/metadata-action#major-version-zero I believe with this, the cognitive load is more or less the same. LMKWYT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
About the changes
This PR removes one workflow file and merges it into a similar workflow file, these are the differences:
This should help improving maintainability of the workflows