Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: simplify workflows #3902

Merged
merged 5 commits into from
Jun 5, 2023
Merged

chore: simplify workflows #3902

merged 5 commits into from
Jun 5, 2023

Conversation

gastonfournier
Copy link
Contributor

About the changes

This PR removes one workflow file and merges it into a similar workflow file, these are the differences:
image

This should help improving maintainability of the workflows

@vercel
Copy link

vercel bot commented Jun 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Jun 5, 2023 11:47am
unleash-monorepo-frontend ⬜️ Ignored (Inspect) Jun 5, 2023 11:47am

Copy link
Contributor

@chriswk chriswk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the change, but I still have to ask if this really lowers cognitive load?
Now we have to parse a more complicated workflow file, and pay attention to the step ids to know what's going on.

Still a 👍, because I do most heartily agree that we have too many workflows going on.

@gastonfournier
Copy link
Contributor Author

I like the change, but I still have to ask if this really lowers cognitive load? Now we have to parse a more complicated workflow file, and pay attention to the step ids to know what's going on.

Still a +1, because I do most heartily agree that we have too many workflows going on.

@chriswk I was also concerned about the cognitive load when adding two conditional steps. I dig a bit further and came up with some changes using something similar to https://github.com/docker/metadata-action#major-version-zero

I believe with this, the cognitive load is more or less the same. LMKWYT

Copy link
Contributor

@gardleopard gardleopard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gastonfournier gastonfournier merged commit 6af7232 into main Jun 5, 2023
10 checks passed
@gastonfournier gastonfournier deleted the simplify-workflows branch June 5, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants