Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: usage on context fields in list #3906

Merged
merged 7 commits into from
Jun 6, 2023
Merged

feat: usage on context fields in list #3906

merged 7 commits into from
Jun 6, 2023

Conversation

sjaanus
Copy link
Contributor

@sjaanus sjaanus commented Jun 6, 2023

image

@vercel
Copy link

vercel bot commented Jun 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2023 11:02am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Jun 6, 2023 11:02am

import getLogger from '../../../fixtures/no-logger';

let db;
let app;
let app: IUnleashTest;
Copy link
Contributor Author

@sjaanus sjaanus Jun 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will add test in separate PR

Copy link
Contributor

@kwasniew kwasniew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non blocking approve but please check the comments

frontend/src/component/context/ContextList/ContextList.tsx Outdated Show resolved Hide resolved
Cell: ({ row: { original } }: any) => (
<TextCell
sx={{
color:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic should be touched by some unit test

frontend/src/interfaces/context.ts Show resolved Hide resolved
src/lib/db/context-field-store.ts Show resolved Hide resolved
src/lib/db/context-field-store.ts Show resolved Hide resolved
@sjaanus sjaanus merged commit 0efaa34 into main Jun 6, 2023
9 of 11 checks passed
@sjaanus sjaanus deleted the usage-of-context branch June 6, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants