Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display strategy title and type #3908

Merged
merged 2 commits into from
Jun 6, 2023
Merged

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented Jun 6, 2023

About the changes

  • displaying strategy name and type at the same time
Screenshot 2023-06-06 at 11 29 04
  • when configuring default strategy also description is added as it was before
Screenshot 2023-06-06 at 11 29 31
  • added a test as this piece of code wasn't covered before

Important files

Discussion points

@vercel
Copy link

vercel bot commented Jun 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2023 10:32am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Jun 6, 2023 10:32am

Copy link
Contributor

@sjaanus sjaanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, but I am not sure how good this goes with our general plan to just keep single type. Ideally we do not want to show the type, because everyone will be just using gradual.

But for now, I guess it is fine.

Copy link
Contributor

@thomasheartman thomasheartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good 😄 Just curious about that one test name 🤔

flags: { strategyImprovements: true },
});

test('should render authorization error on missing old password', async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this test description accurate? What here relates to a password?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch of copy paste :)

@kwasniew kwasniew merged commit 44f752e into main Jun 6, 2023
17 checks passed
@kwasniew kwasniew deleted the display-strategy-name-and-title branch June 6, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants