Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unnecessary build #3910

Merged
merged 1 commit into from
Jun 6, 2023
Merged

Conversation

gastonfournier
Copy link
Contributor

@gastonfournier gastonfournier commented Jun 6, 2023

About the changes

This removes unnecessary build that's already triggered as part of the prepare script

"prepare": "node scripts/husky-install && yarn --cwd ./frontend install && if [ ! -d ./dist ]; then yarn build; fi",

This should reduce the build time of this action: https://github.com/Unleash/unleash/actions/workflows/docker_publish.yaml (currently at 30m)

We can see the double execution from the log files of one execution:

$ grep " #14 " 1_build\ \(18-alpine\).txt  | grep "build:frontend" | grep built
2023-06-06T11:20:25.6513037Z #14 1198.7 [build:frontend] ✓ built in 7m 48s
2023-06-06T11:28:35.0518703Z #14 1688.1 [build:frontend] ✓ built in 7m 34s

That is step 14 executing build:frontend twice

@vercel
Copy link

vercel bot commented Jun 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Jun 6, 2023 0:56am
unleash-monorepo-frontend ⬜️ Ignored (Inspect) Jun 6, 2023 0:56am

Copy link
Contributor

@chriswk chriswk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@gastonfournier gastonfournier merged commit a08c6f3 into main Jun 6, 2023
12 checks passed
@gastonfournier gastonfournier deleted the optimize-docker-build branch June 6, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants