Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clarify error logs #3915

Merged
merged 3 commits into from
Jun 7, 2023
Merged

chore: clarify error logs #3915

merged 3 commits into from
Jun 7, 2023

Conversation

thomasheartman
Copy link
Contributor

This change makes the logs that happen when we encounter an error a
little bit clearer. It logs the error message before the error ID and
also logs the full serialized message just in case.

This change makes the logs that happen when we encounter an error a
little bit clearer. It logs the error message before the error ID and
also logs the full serialized message just in case.
@vercel
Copy link

vercel bot commented Jun 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Jun 7, 2023 11:51am
unleash-monorepo-frontend ⬜️ Ignored (Inspect) Jun 7, 2023 11:51am

Copy link
Contributor

@sjaanus sjaanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, lets see how the logs will change.

@thomasheartman thomasheartman enabled auto-merge (squash) June 7, 2023 11:38
@thomasheartman thomasheartman enabled auto-merge (squash) June 7, 2023 11:53
@thomasheartman thomasheartman merged commit 03dd7b6 into main Jun 7, 2023
10 checks passed
@thomasheartman thomasheartman deleted the chore/improve-error-logs branch June 7, 2023 12:11
thomasheartman added a commit that referenced this pull request Jun 7, 2023
This change makes the logs that happen when we encounter an error a
little bit clearer. It logs the error message before the error ID and
also logs the full serialized message just in case.
thomasheartman added a commit that referenced this pull request Jun 7, 2023
This change makes the logs that happen when we encounter an error a
little bit clearer. It logs the error message before the error ID and
also logs the full serialized message just in case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants