Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: avoid building frontend twice #3918

Merged
merged 1 commit into from
Jun 8, 2023
Merged

chore: avoid building frontend twice #3918

merged 1 commit into from
Jun 8, 2023

Conversation

gastonfournier
Copy link
Contributor

@gastonfournier gastonfournier commented Jun 7, 2023 •
edited

About the changes

Running yarn install without the dist folder will trigger a yarn build automatically as part of the prepare script

As we can see here: https://github.com/Unleash/unleash/actions/runs/5200272004/jobs/9378770279

[build:frontend] ✓ built in 41.10s
// more output
[build:frontend] ✓ built in 39.81s

@vercel
Copy link

vercel bot commented Jun 7, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Jun 7, 2023 1:18pm
unleash-monorepo-frontend ⬜️ Ignored (Inspect) Jun 7, 2023 1:18pm

@gastonfournier gastonfournier self-assigned this Jun 7, 2023
thomasheartman
thomasheartman approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@thomasheartman thomasheartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@gastonfournier gastonfournier merged commit 51fc8f0 into main Jun 8, 2023
12 checks passed
@gastonfournier gastonfournier deleted the optimize-release-workflow branch June 8, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasheartman thomasheartman thomasheartman approved these changes

Assignees

@gastonfournier gastonfournier

Labels
None yet
Projects
Issues and PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gastonfournier @thomasheartman