Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: update stickiness docs #3928

Merged
merged 4 commits into from
Jun 13, 2023
Merged

Docs: update stickiness docs #3928

merged 4 commits into from
Jun 13, 2023

Conversation

andreas-unleash
Copy link
Contributor

About the changes

Closes #

Important files

Discussion points

@andreas-unleash
Docs: update stickiness docs
7aa354a 
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
@vercel
Copy link

vercel bot commented Jun 8, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2023 10:02am
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2023 10:02am

thomasheartman
thomasheartman requested changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@thomasheartman thomasheartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good, but I have some suggestions I'd like to run by you before we merge this. There's also one more update that we should do: in unleash-context.md, there is a custom stickiness section that has a similar note to the one in stickiness. I think we can do the same thing to that note: mention that only the Rust SDK doesn't support it, and link to the table.

What do you think? 😄

website/docs/reference/stickiness.md Outdated Show resolved Hide resolved
website/docs/reference/stickiness.md Outdated Show resolved Hide resolved
website/static/img/proect_default_stickiness.png Outdated Show resolved Hide resolved
andreas-unleash and others added 2 commits June 12, 2023 12:48
@andreas-unleash @thomasheartman
Update website/docs/reference/stickiness.md
4fa0746 
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
@andreas-unleash
Docs: fix PR comments
c88a609 
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
@andreas-unleash
Copy link
Contributor Author

This looks pretty good, but I have some suggestions I'd like to run by you before we merge this. There's also one more update that we should do: in unleash-context.md, there is a custom stickiness section that has a similar note to the one in stickiness. I think we can do the same thing to that note: mention that only the Rust SDK doesn't support it, and link to the table.

What do you think? 😄

Sounds good, found another place (activation_strategies.md) and replaced the note there as well

@andreas-unleash
Merge remote-tracking branch 'origin/docs/update_stickiness' into doc…
4acd0cd 
…s/update_stickiness

# Conflicts:
#	website/docs/reference/stickiness.md
thomasheartman
thomasheartman approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@thomasheartman thomasheartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good! Thank you 👏🏼

@andreas-unleash andreas-unleash merged commit 8daab71 into main Jun 13, 2023
12 of 16 checks passed
@andreas-unleash andreas-unleash deleted the docs/update_stickiness branch June 13, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasheartman thomasheartman thomasheartman approved these changes

Assignees

@andreas-unleash andreas-unleash

Labels
None yet
Projects
Issues and PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andreas-unleash @thomasheartman