Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add createdAt in projects API response #3929

Merged
merged 4 commits into from
Jun 9, 2023
Merged

fix: add createdAt in projects API response #3929

merged 4 commits into from
Jun 9, 2023

Conversation

ivarconr
Copy link
Member

@ivarconr ivarconr commented Jun 8, 2023

This PR adds the "createdAt" field to the /api/projects response, so that we are compliant with the schema.

@vercel
Copy link

vercel bot commented Jun 8, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 9, 2023 2:12pm
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 9, 2023 2:12pm

@ivarconr ivarconr requested a review from sjaanus June 8, 2023 14:05
thomasheartman
thomasheartman approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@thomasheartman thomasheartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

But what about the mapRow function on line 555 of src/lib/db/project-store.ts? It also doesn't include createdAt. Is this something we should update too? I'm not sure exactly where it's called from (transitively).

@ivarconr
Copy link
Member Author

ivarconr commented Jun 8, 2023

But what about the mapRow function on line 555 of src/lib/db/project-store.ts? It also doesn't include createdAt

I am confused 🤔 does it not map the createdAt on line 564?

@thomasheartman
Copy link
Contributor

I am confused 🤔 does it not map the createdAt on line 564?

Oh, sorry, I'm confused. I must've missed that (even though I looked for it specifically). My bad! As you were 😅

@ivarconr ivarconr enabled auto-merge (squash) June 9, 2023 13:57
@ivarconr ivarconr merged commit 1bc130b into main Jun 9, 2023
17 checks passed
@ivarconr ivarconr deleted the fix/project-api-should-include-created_at branch June 9, 2023 14:18
ivarconr added a commit that referenced this pull request Jun 16, 2023
@ivarconr
fix: add createdAt in projects API response (#3929)
e9a5241 
This PR adds the "createdAt" field to the /api/projects response, so
that we are compliant with the schema.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjaanus sjaanus sjaanus left review comments

@thomasheartman thomasheartman thomasheartman approved these changes

Assignees

@ivarconr ivarconr

Labels
None yet
Projects
Issues and PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ivarconr @thomasheartman @sjaanus