Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: context field usage frontend #3938

Merged
merged 3 commits into from
Jun 12, 2023
Merged

feat: context field usage frontend #3938

merged 3 commits into from
Jun 12, 2023

Conversation

sjaanus
Copy link
Contributor

@sjaanus sjaanus commented Jun 9, 2023

image
image

@vercel
Copy link

vercel bot commented Jun 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-docs 🛑 Canceled (Inspect) Jun 9, 2023 9:23am
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 9, 2023 9:23am

Copy link
Contributor

@kwasniew kwasniew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

src/lib/db/segment-store.ts Show resolved Hide resolved
projectId}
</Link>
<ul>
{strategies
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prepare projectStrategies variable outside of JSX to minimize scripting inside HTML tags. I'd only use map operation in JSX, not filter

@sjaanus sjaanus merged commit 9f0d942 into main Jun 12, 2023
12 of 18 checks passed
@sjaanus sjaanus deleted the context-field-fe branch June 12, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants