Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: walking skeleton of the advanced playground #3949

Merged
merged 3 commits into from
Jun 12, 2023

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented Jun 9, 2023

About the changes

  • calling new playground "advanced playground" since it supports advanced search by multiple envs and combinations of context field values
  • new path /playground/advanced (added advanced suffix to the existing URL)
  • added a release toggle called advancedPlayground
  • returning hardcoded response for now to get feedback from UI
  • modelling disabled toggles as 409 - "indicates a request conflict with the current state of the target resource" to express that the current state of the resource is unavailable for the end user and should not be requests at this point in time
  • fixing a bug with missing project in the old playground resource

Next PRs:

  • describe input and output schemas
  • start calling real service to calculate the results

Important files

Discussion points

@vercel
Copy link

vercel bot commented Jun 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 9, 2023 1:09pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Jun 9, 2023 1:09pm

@@ -58,7 +71,7 @@ export default class PlaygroundController extends Controller {
const response = {
input: req.body,
features: await this.playgroundService.evaluateQuery(
req.body.projects,
req.body.projects || '*',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixing a bug we had before when no projects are specified

Copy link
Contributor

@thomasheartman thomasheartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Super work 😄 My only thought before merging this is whether we should discuss the URL first. I'm not entirely sold on /playground/advanced, but I'm not sure whether this needs to be handled yet?

@kwasniew
Copy link
Contributor Author

@thomasheartman Since we're not advertising it as stable API yet and it's behind a flag the name is up for a debate. Want to unblock the UI work first and we can rename it later.

@kwasniew kwasniew merged commit 7b8b6bc into main Jun 12, 2023
17 checks passed
@kwasniew kwasniew deleted the advanced-playground-stub branch June 12, 2023 09:01
@thomasheartman
Copy link
Contributor

That's fair. I noticed there's no OpenAPI docs for it yet, so that's ... kinda good? that said, the Unstable tag was made for things like this, so that should allow us to put it in the docs and work with it.

@kwasniew
Copy link
Contributor Author

@thomasheartman We will be adding OpenAPI docs after we see the data shape is useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants