-
-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: walking skeleton of the advanced playground #3949
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
@@ -58,7 +71,7 @@ export default class PlaygroundController extends Controller { | |||
const response = { | |||
input: req.body, | |||
features: await this.playgroundService.evaluateQuery( | |||
req.body.projects, | |||
req.body.projects || '*', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixing a bug we had before when no projects are specified
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! Super work 😄 My only thought before merging this is whether we should discuss the URL first. I'm not entirely sold on /playground/advanced, but I'm not sure whether this needs to be handled yet?
@thomasheartman Since we're not advertising it as stable API yet and it's behind a flag the name is up for a debate. Want to unblock the UI work first and we can rename it later. |
That's fair. I noticed there's no OpenAPI docs for it yet, so that's ... kinda good? that said, the |
@thomasheartman We will be adding OpenAPI docs after we see the data shape is useful. |
About the changes
Next PRs:
Important files
Discussion points