-
-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: context/segment usage plausible #3956
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
non blocking approve with comments
const trackClick = () => { | ||
trackEvent('segment-usage', { | ||
props: { | ||
eventType: 'segment usage browsed', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure about "browsed". Maybe viewed/checked
const projectList = ( | ||
<StyledUl> | ||
{Array.from(projectsUsed).map(projectId => ( | ||
<li key={projectId}> | ||
<li key={projectId} onClick={trackClick}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should there be some other action other than trackClick on click?
@@ -4,6 +4,7 @@ import { IProjectCard } from 'interfaces/project'; | |||
import { IFeatureStrategy } from 'interfaces/strategy'; | |||
import { Link } from 'react-router-dom'; | |||
import { formatStrategyName } from 'utils/strategyNames'; | |||
import { usePlausibleTracker } from '../../hooks/usePlausibleTracker'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove dots
No description provided.