Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: context/segment usage plausible #3956

Merged
merged 2 commits into from
Jun 12, 2023
Merged

Conversation

sjaanus
Copy link
Contributor

@sjaanus sjaanus commented Jun 12, 2023

No description provided.

@vercel
Copy link

vercel bot commented Jun 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2023 9:33am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Jun 12, 2023 9:33am

Copy link
Contributor

@kwasniew kwasniew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non blocking approve with comments

const trackClick = () => {
trackEvent('segment-usage', {
props: {
eventType: 'segment usage browsed',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure about "browsed". Maybe viewed/checked

const projectList = (
<StyledUl>
{Array.from(projectsUsed).map(projectId => (
<li key={projectId}>
<li key={projectId} onClick={trackClick}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should there be some other action other than trackClick on click?

@@ -4,6 +4,7 @@ import { IProjectCard } from 'interfaces/project';
import { IFeatureStrategy } from 'interfaces/strategy';
import { Link } from 'react-router-dom';
import { formatStrategyName } from 'utils/strategyNames';
import { usePlausibleTracker } from '../../hooks/usePlausibleTracker';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove dots

@sjaanus sjaanus merged commit 4a2867b into main Jun 12, 2023
11 of 17 checks passed
@sjaanus sjaanus deleted the context-segment-plausible branch June 12, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants