fix: feature not found in project yields 404 #3958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
gastonfournier
commented
Jun 12, 2023
| @@ -11,7 +11,7 @@ export interface IFeatureToggleQuery { | |||
| export interface IFeatureToggleStore extends Store<FeatureToggle, string> { | |||
| count(query?: Partial<IFeatureToggleQuery>): Promise<number>; | |||
| setLastSeen(toggleNames: string[]): Promise<void>; | |||
| getProjectId(name: string): Promise<string>; | |||
| getProjectId(name: string): Promise<string | undefined>; | |||
There was a problem hiding this comment.
There's a chance that we don't find the project id if the feature does not exist at all
gastonfournier
commented
Jun 12, 2023
| `There's no feature named ${featureName} in project ${projectId} ${ | ||
| id === undefined | ||
| ? '.' | ||
| : `, but there's a feature by that name in project "${id}"` |
There was a problem hiding this comment.
Not sure if we should provide this information in the API, but I'm just keeping the message closer to the one in the left
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
When a feature is not found in a project we should fail with a NotFound error. If the feature belongs to a different project, it should not be a permission issue, because the user might not be aware (lack of permissions/visibility) of that other project, so even in this case the error should be NotFound (this also works if we ever allow the same feature name in different projects)
Fixes #3726