feat: draft branch playground evaluation #3967
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
| environment: string; | ||
| }; | ||
|
|
||
| type AdvancedPlaygroundFeatureSchema = PlaygroundFeatureSchema & { |
There was a problem hiding this comment.
This will be openapi schema once we define it, but for now I neded to add extra context and environment info to prepare UI specific read model
| @@ -42,34 +50,49 @@ export class PlaygroundService { | |||
| projects: typeof ALL | string[], | |||
| environments: string[], | |||
| context: SdkContextSchema, | |||
| ): Promise<PlaygroundFeatureSchema[]> { | |||
| ): Promise<any> { | |||
There was a problem hiding this comment.
this type will be openapi defined in the next PR
| entries, | ||
| (entry) => entry.environment, | ||
| ); | ||
| return { |
There was a problem hiding this comment.
it creates the same structure as we had in the hardcoded response
| ); | ||
| return { | ||
| name, | ||
| projectId: entries[0]?.projectId, |
There was a problem hiding this comment.
we can take any entry in the group so I take the first one since it's always there
| @@ -112,18 +135,22 @@ export class PlaygroundService { | |||
| projectId: featureProject[feature.name], | |||
| variant: client.getVariant(feature.name, clientContext), | |||
| name: feature.name, | |||
| environment, | |||
There was a problem hiding this comment.
I'm passing environment and context from input to output because the new UI requires those values
| context, | ||
| environment, | ||
| }); | ||
| return result.map((item) => omitKeys(item, 'environment', 'context')); |
There was a problem hiding this comment.
old playground shouldn't get environment and context that we evaluate for the new playground
About the changes
Drafting batch playground/advanced evaluations instead of a hardcoded response.
Next PR:
Important files
Discussion points