Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: advanced playground #3968

Merged
merged 2 commits into from
Jun 14, 2023
Merged

test: advanced playground #3968

merged 2 commits into from
Jun 14, 2023

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented Jun 13, 2023

About the changes

  • added test for the advanced search (e2e/component test for now so that we can do aggressive refactoring inside the code)
  • removed hardcoded response because we have a test documenting example API response

Next PR:

  • start adding openapi types

Important files

Discussion points

@vercel
Copy link

vercel bot commented Jun 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Jun 13, 2023 1:09pm
unleash-monorepo-frontend ⬜️ Ignored (Inspect) Jun 13, 2023 1:09pm

{
experimental: {
flags: {
advancedPlayground: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we are at it, perhaps strictSchemaValidation?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless it touches too difficult schemas, like strategies etc, which need more work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll be adding openapi in the next PR so flag will be added only then

Copy link
Contributor

@thomasheartman thomasheartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🏆

@kwasniew kwasniew merged commit edd67f7 into main Jun 14, 2023
10 checks passed
@kwasniew kwasniew deleted the advanced-plaground-e2e-test branch June 14, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants