Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set unleash version to be either the enterprise version or OSS #3974

Merged
merged 2 commits into from
Jun 13, 2023

Conversation

gastonfournier
Copy link
Contributor

About the changes

Unleash version should be the one best representing its runtime. In this regard, enterpriseVersion trumps unleash-server version.

This version is the one that's sent as part of our metrics.

@gastonfournier gastonfournier self-assigned this Jun 13, 2023
@vercel
Copy link

vercel bot commented Jun 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Jun 13, 2023 4:22pm
unleash-monorepo-frontend ⬜️ Ignored (Inspect) Jun 13, 2023 4:22pm

Copy link
Contributor

@chriswk chriswk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're right here. Enterprise version is more interesting than the oss version.

@gastonfournier
Copy link
Contributor Author

I'm going to merge and test. If it goes wrong I'll revert it

@gastonfournier gastonfournier merged commit 30b16be into main Jun 13, 2023
10 checks passed
@gastonfournier gastonfournier deleted the unleash-version branch June 13, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants