docs: mark 'yes' and no as required, add more details to variants
#3984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a little more detail to the client metrics schema. Some of the properties were incorrectly marked as optional (`yes` and `no` must always be present), and the description for variants felt a little unclear.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
chriswk
approved these changes
Jun 15, 2023
chriswk
reviewed
Jun 15, 2023
src/test/e2e/api/openapi/__snapshots__/openapi.e2e.test.ts.snap
Outdated
Show resolved
Hide resolved
Co-authored-by: Christopher Kolstad <chriswk@getunleash.ai>
thomasheartman
commented
Jun 15, 2023
Co-authored-by: Christopher Kolstad <chriswk@getunleash.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a little more detail to the client metrics schema. The description for variants felt a
little unclear.