Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:playground environment table #3985

Merged
merged 3 commits into from
Jun 15, 2023
Merged

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented Jun 15, 2023

About the changes

  • adding environment playground table (most columns are dynamic based on context fields)
Screenshot 2023-06-15 at 08 47 25

Next PRs:

  • unit test
  • adding a modal around the table
  • connecting to the advanced results table

Important files

Discussion points

@vercel
Copy link

vercel bot commented Jun 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 15, 2023 7:29am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Jun 15, 2023 7:29am

const dynamicHeaders = Object.keys(features[0].context)
.filter(contextField => contextField !== 'appName')
.map(contextField => ({
Header: contextField,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would capitalize the first letter of the context field for the Header

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will check with Nico because in the design he had lowercase and I'm not sure whether it's not gonna be confusing since the context uses lower cased ones.

@kwasniew kwasniew merged commit 9853aa0 into main Jun 15, 2023
15 of 17 checks passed
@kwasniew kwasniew deleted the playground-environment-table branch June 15, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants