fix: usage of default strategy #3995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
sjaanus
commented
Jun 15, 2023
| Boolean(uiConfig.flags.strategyImprovements) && | ||
| strategy !== undefined | ||
| } | ||
| condition={Boolean(uiConfig.flags.strategyImprovements)} |
sjaanus
commented
Jun 15, 2023
| @@ -20,7 +20,7 @@ import { ProjectDefaultStrategyForm } from './ProjectDefaultStrategyForm'; | |||
| import { CreateFeatureStrategySchema } from 'openapi'; | |||
| import useProject from 'hooks/api/getters/useProject/useProject'; | |||
|
|
|||
| const DEFAULT_STRATEGY = { | |||
| export const DEFAULT_STRATEGY = { | |||
sjaanus
commented
Jun 15, 2023
| @@ -98,7 +99,7 @@ export const FeatureStrategyCreate = () => { | |||
|
|
|||
| useEffect(() => { | |||
| if (useDefaultStrategy) { | |||
| setStrategy((defaultStrategy as any) || {}); | |||
| setStrategy((defaultStrategy as any) || DEFAULT_STRATEGY); | |||
There was a problem hiding this comment.
If user has not defined, use the global default one.
kwasniew
approved these changes
Jun 19, 2023
| @@ -12,7 +12,8 @@ interface IFeatureStrategyMenuCardProps { | |||
| projectId: string; | |||
| featureId: string; | |||
| environmentId: string; | |||
| strategy: IStrategy; | |||
| strategy: Pick<IStrategy, 'name' | 'displayName' | 'description'> & | |||
There was a problem hiding this comment.
Is there a type alias that could give it a descriptive name why we pick those fields in particular?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now when user has not defined project default strategy, the default strategy will be used.
Simplify usage and rely on existing constant.