fix: add trial expired warning for enterprise #3997
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
| @@ -104,7 +104,7 @@ export const InstanceStatus: FC = ({ children }) => { | |||
| return ( | |||
| <> | |||
| <ConditionallyRender | |||
| condition={isBilling && Boolean(instanceStatus)} | |||
| condition={Boolean(instanceStatus)} | |||
There was a problem hiding this comment.
If I understood this correctly, we want isBilling to only represent plans that we show the billing page for (invoices, etc). That's why we removed it from this condition and have not added ENTERPRISE to the billing plans.
I think this is a safe change, both the bar and the dialog should only get displayed in case we have specific information from the instance status (e.g. has expired).
I would recommend removing isBilling from the destructor above since it's now unused.
There was a problem hiding this comment.
I would recommend removing isBilling from the destructor above since it's now unused.
Yes!
| @@ -82,6 +82,7 @@ export const BillingPlan: FC<IBillingPlanProps> = ({ instanceStatus }) => { | |||
| [InstancePlan.PRO]: 80, | |||
| [InstancePlan.COMPANY]: 0, | |||
| [InstancePlan.TEAM]: 0, | |||
| [InstancePlan.ENTERPRISE]: 0, | |||
There was a problem hiding this comment.
According to https://github.com/Unleash/unleash/pull/3997/files#r1232089348 I don't think we need this.
| [InstancePlan.ENTERPRISE]: 0, |
Adds the trial expired warning for enterprise as well.