Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: roles unification #3999

Merged
merged 2 commits into from
Jun 19, 2023
Merged

feat: roles unification #3999

merged 2 commits into from
Jun 19, 2023

Conversation

nunogois
Copy link
Member

https://linear.app/unleash/issue/2-1137/roles-unification-on-the-ui

Root and project roles should be managed in a similar manner, which means using the same roles route and tab for both.

Additionally, this includes a big revamp to the project roles to align them more closely with the modern and standardized custom root roles that were recently developed. They mostly use the same components.

There are still more things we want to improve and unify, but we've left some of that out of this PR due to PR size concerns.

@vercel
Copy link

vercel bot commented Jun 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 16, 2023 2:02pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Jun 16, 2023 2:02pm

Copy link
Contributor

@chriswk chriswk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job. Also noticed the fact that this PR manages to reuse more components (visible from the fact that the delta sum is -700 lines of code)

@nunogois nunogois merged commit eb8f16d into main Jun 19, 2023
17 checks passed
@nunogois nunogois deleted the roles-unification branch June 19, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants