-
-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Playground environment diff table #4002
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -24,7 +24,7 @@ import { AdvancedPlaygroundResponseSchema } from 'openapi'; | |||
export const AdvancedPlayground: VFC<{}> = () => { | |||
const { environments: availableEnvironments } = useEnvironments(); | |||
const theme = useTheme(); | |||
const matches = useMediaQuery(theme.breakpoints.down('lg')); | |||
const matches = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UI breaks on limited space we have in the right area so forcing mobile view for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With breaks
, do you mean the overflow ?
@@ -108,6 +108,11 @@ export const PlaygroundEnvironmentTable = ({ | |||
columns: COLUMNS as any, | |||
data: features, | |||
sortTypes, | |||
autoResetGlobalFilter: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixing sorting to be consistent with other views
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
About the changes
Next PRs:
Important files
Discussion points