Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: filter out usage for export #4006

Merged
merged 1 commit into from
Jun 19, 2023
Merged

fix: filter out usage for export #4006

merged 1 commit into from
Jun 19, 2023

Conversation

sjaanus
Copy link
Contributor

@sjaanus sjaanus commented Jun 19, 2023

Will be filtering out usage counts for export, because:

  1. This is the same pattern we are doing for other objects. Filtering out not needed fields.
  2. Reducing the payload. This data is not needed for importing.

@vercel
Copy link

vercel bot commented Jun 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Jun 19, 2023 10:32am
unleash-monorepo-frontend ⬜️ Ignored (Inspect) Jun 19, 2023 10:32am

kwasniew
kwasniew approved these changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@kwasniew kwasniew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So was it breaking the output schema?

@sjaanus
Copy link
Contributor Author

sjaanus commented Jun 19, 2023

So was it breaking the output schema?

It was not breaking output schema.

@sjaanus sjaanus merged commit 9c86518 into main Jun 19, 2023
11 checks passed
@sjaanus sjaanus deleted the usage-export branch June 19, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwasniew kwasniew kwasniew approved these changes

Assignees

@sjaanus sjaanus

Labels
None yet
Projects
Issues and PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sjaanus @kwasniew