Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: store playground settings in local storage #4012

Merged
merged 6 commits into from
Jun 20, 2023

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented Jun 19, 2023

About the changes

Important files

Discussion points

@vercel
Copy link

vercel bot commented Jun 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2023 8:35am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Jun 20, 2023 8:35am

const testComponent = (
<UIProviderContainer>
<AdvancedPlayground
FormComponent={props => (
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test form is used for easy data rendering verification

);
await evaluatePlaygroundContext(environments, projects, context, () => {
setURLParameters();
setValue({
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saving new values to local storage after successful evaluation

import { createLocalStorage } from '../../../utils/createLocalStorage';

export const AdvancedPlayground: VFC<{
FormComponent?: typeof PlaygroundForm;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependency Injection for difficult to test component

@kwasniew kwasniew merged commit 2e4f557 into main Jun 20, 2023
17 checks passed
@kwasniew kwasniew deleted the store-playground-settings branch June 20, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants