Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task: Make keepalive configurable via an environment variable #4015

Merged
merged 2 commits into from
Jun 20, 2023

Conversation

chriswk
Copy link
Contributor

@chriswk chriswk commented Jun 20, 2023

As requested in Linear this PR makes the serverKeepAliveTimeout configurable via the SERVER_KEEPALIVE_TIMEOUT environment variable. This was already configurable when starting Unleash programmatically, but it's nice to have as an env variable as well

@vercel
Copy link

vercel bot commented Jun 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2023 8:00am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ⬜️ Ignored (Inspect) Jun 20, 2023 8:00am

Copy link
Contributor

@gardleopard gardleopard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kickass!!!

@chriswk chriswk merged commit fa081e9 into main Jun 20, 2023
12 checks passed
@chriswk chriswk deleted the task/makeKeepAliveConfigurable branch June 20, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants