fix: reject API admin tokens when importing features #4016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kwasniew
approved these changes
Jun 20, 2023
src/lib/features/export-import-toggles/export-import-api-usage.test.ts
Outdated
Show resolved
Hide resolved
src/lib/features/export-import-toggles/export-import-api-usage.test.ts
Outdated
Show resolved
Hide resolved
src/lib/features/export-import-toggles/export-import-api-usage.test.ts
Outdated
Show resolved
Hide resolved
|
Yeah, great catch. I've shaved off a bunch of lines for that 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where trying to use an admin token to import features via the API resulted in a 500 (due to missing properties).
The solution is to catch when the user is using and admin token in the controller, throw a 400, and tell them to use personal access tokens or service accounts.
The PR includes a new test file for this specific use case. We don't really test these cases many other places, so it seemed the logical choice.