Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query complexity validation #4017

Merged
merged 5 commits into from
Jun 20, 2023
Merged

Query complexity validation #4017

merged 5 commits into from
Jun 20, 2023

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented Jun 20, 2023

About the changes

This PR adds capability to reject playground queries that are too complex (over 30k results)
Screenshot 2023-06-20 at 13 10 01

Details:

  • complexity calculated by multiplying number of features, envs, context combinations
  • complexity is calculated in the backend code and results are returned to UI
  • UI alert box is reset after another form resubmission, not when the input data is changed. You may want to see the error for some time and not have it disappear instantly after the first change

Next PR:

  • UI tests for failed form submission

Important files

Discussion points

@vercel
Copy link

vercel bot commented Jun 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2023 11:09am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Jun 20, 2023 11:09am

Copy link
Contributor

@andreas-unleash andreas-unleash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@kwasniew kwasniew merged commit a0862cf into main Jun 20, 2023
16 of 17 checks passed
@kwasniew kwasniew deleted the query-complexity-validation branch June 20, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants