-
-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: document how and why we collect data when using Unleash #4020
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, remove the OIDC and SAML parts then it's awesome!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work! It's clear, well structured, and makes it easy for end users to see what we collect and how they can disable it. Only got a small request to reorder the sidebar. 💯
## Managing data collection settings {#managing-data-collection-settings} | ||
We understand that privacy preferences may vary among our users. While the data collected by Unleash is limited and anonymous, we provide options to manage data collection settings: | ||
|
||
**Disabling All Telemetry**: If you have previously disabled the version telemetry by setting the environment variable `CHECK_VERSION` to anything other than "true," both the version telemetry and the feature telemetry will be disabled. This respects your choice to opt out of all telemetry data if you had previously disabled it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering: is the env variable case sensitive? That is, will "True" also collect metrics? We should probably be clear about that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, that was a great a question. So I went and looked. In practise this actually does 3 checks: a case sensitive check for "true", a case sensitive check for "t" and a case sensitive check for the string "1". I've updated the docs here to reflect this
…ct and expand on the variables for disabling it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This adds documentation for how we collect data in Unleash. Previously this had been a very small amount of data but it was quite hidden in our docs in terms of what it did and why. This makes this extremely explicit, with guidelines on how to disable it and confirmation that previously disabling data collection will continue to work as expected