Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test advanced playground error #4023

Merged
merged 5 commits into from
Jun 21, 2023
Merged

Conversation

kwasniew
Copy link
Contributor

About the changes

Playground form evaluation: testing that error banner is displayed on backend returning 400 and error message.

Important files

Discussion points

@vercel
Copy link

vercel bot commented Jun 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2023 6:03am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Jun 21, 2023 6:03am

<UIProviderContainer>
<AdvancedPlayground
FormComponent={props => (
<form onSubmit={props.onSubmit}>
Copy link
Contributor Author

@kwasniew kwasniew Jun 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of using real form with hard to test code mirror I use/inject the test form. The important stuff is that it calls onSubmit from the parent component owning the state.

Copy link
Contributor

@thomasheartman thomasheartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this looks pretty good to me 😄

@kwasniew kwasniew merged commit a5ee50c into main Jun 21, 2023
14 of 17 checks passed
@kwasniew kwasniew deleted the test-advanced-playground-error branch June 21, 2023 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants