-
-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test advanced playground error #4023
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
<UIProviderContainer> | ||
<AdvancedPlayground | ||
FormComponent={props => ( | ||
<form onSubmit={props.onSubmit}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of using real form with hard to test code mirror I use/inject the test form. The important stuff is that it calls onSubmit from the parent component owning the state.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this looks pretty good to me 😄
About the changes
Playground form evaluation: testing that error banner is displayed on backend returning 400 and error message.
Important files
Discussion points