Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initial scroll trigger #4036

Merged
merged 1 commit into from
Jun 21, 2023
Merged

feat: initial scroll trigger #4036

merged 1 commit into from
Jun 21, 2023

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented Jun 21, 2023

About the changes

I found an issue where a virtual list is nested inside another virtual list the nested one didn't render anything for below the fold/lazy elements from the parent list unless we scrolled inside the child list. This change triggers initial scroll when a component is loaded.

Screenshot 2023-06-21 at 13 55 45

Important files

Discussion points

@vercel
Copy link

vercel bot commented Jun 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2023 0:13am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Jun 21, 2023 0:13am

@kwasniew kwasniew merged commit 91f1072 into main Jun 21, 2023
19 checks passed
@kwasniew kwasniew deleted the initial-scroll-trigger branch June 21, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants