feat: advanced playground multi value context fields #4053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
kwasniew
approved these changes
Jun 22, 2023
There was a problem hiding this comment.
Non blocking approval but I'd extract descriptive methods for switching between single string and list of strings. Those are two symmetrical operations that can be kept close together so that we know they are two sides of the same coin. Also once we extract two symmetrical methods we can easily unit test the swapping logic.
...onent/playground/Playground/PlaygroundForm/PlaygroundCodeFieldset/PlaygroundCodeFieldset.tsx
Outdated
Show resolved
Hide resolved
...onent/playground/Playground/PlaygroundForm/PlaygroundCodeFieldset/PlaygroundCodeFieldset.tsx
Outdated
Show resolved
Hide resolved
...onent/playground/Playground/PlaygroundForm/PlaygroundCodeFieldset/PlaygroundCodeFieldset.tsx
Outdated
Show resolved
Hide resolved
...onent/playground/Playground/PlaygroundForm/PlaygroundCodeFieldset/PlaygroundCodeFieldset.tsx
Outdated
Show resolved
Hide resolved
...onent/playground/Playground/PlaygroundForm/PlaygroundCodeFieldset/PlaygroundCodeFieldset.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the autocomplete component in the playground context field - when selecting a custom context field that has legal values - able to select/edit multiple values.
About the changes
Closes # 1-1006
Important files
Discussion points