-
-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: plausible for new strategy flow #4057
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blocking approve. Questionable naming conventions.
@@ -65,7 +76,7 @@ export const FeatureStrategyMenu = ({ | |||
permission={CREATE_FEATURE_STRATEGY} | |||
projectId={projectId} | |||
environmentId={environmentId} | |||
onClick={() => navigate(createStrategyPath)} | |||
onClick={onClick} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about giving it a descriptive name so that I know when business operation onClick performs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see similar naming anti-pattern in other places in this file. e.g. onClick={onClose}. I'd expect onClick={businessOperationName}
No description provided.