feat: link to strategy edit screens from playground strategy results #4063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
kwasniew
requested changes
Jun 22, 2023
| @@ -106,6 +107,13 @@ export const StrategyItemContainer: FC<IStrategyItemContainerProps> = ({ | |||
| const Icon = getFeatureStrategyIcon(strategy.name); | |||
| const { uiConfig } = useUiConfig(); | |||
|
|
|||
| // @ts-expect-error IFeatureStrategy doesn't have links | |||
There was a problem hiding this comment.
I would solve it without ignoring typechecker. When I checked out your branch none of the union elements had a links field
There was a problem hiding this comment.
AFter we get the links on one of the union element we can play around with type aliases and ternany operators so that we don't have to opt out of type safety
There was a problem hiding this comment.
Fair! I'll rebase off main now that the Orval updates have been merged and see if that fixes it.
There was a problem hiding this comment.
Found out that you can use the 'x' in y pattern in d10a54b. Seems like it does just what we want?
thomasheartman
force-pushed
the
feat/link-to-strategy-edit-screen-from-playground
branch
from
26cc9ff
to
d10a54b
Compare
kwasniew
approved these changes
Jun 22, 2023
thomasheartman
deleted the
feat/link-to-strategy-edit-screen-from-playground
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds links from the strategy evaluation results directly to the strategy edit screen.
If the code doesn't find any links, nothing changes.
The link text will be the name of the strategy and the title (if it exists).