feat: execution plan diff table #4065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
kwasniew
commented
Jun 22, 2023
| }, | ||
| sortType: 'playgroundResultState', | ||
| maxWidth: 120, | ||
| maxWidth: 140, |
There was a problem hiding this comment.
more space for the info icon to avoid horizontal scroll
kwasniew
commented
Jun 22, 2023
| @@ -54,10 +55,21 @@ export const PlaygroundEnvironmentDiffTable = ({ | |||
| ? 'unknown' | |||
| : 'false', | |||
| Cell: ({ row }: { row: { original: RowType } }) => { | |||
| return <FeatureStatusCell feature={row.original[environment]} />; | |||
| return ( | |||
| <Box sx={{ display: 'flex' }}> | |||
There was a problem hiding this comment.
flex to inline two elements into one cell
kwasniew
commented
Jun 22, 2023
| @@ -10,7 +10,7 @@ interface IFeatureStatusCellProps { | |||
| const StyledCellBox = styled(Box)(({ theme }) => ({ | |||
| display: 'flex', | |||
| alignItems: 'center', | |||
| padding: theme.spacing(1, 2), | |||
| padding: theme.spacing(1, 0, 1, 2), | |||
There was a problem hiding this comment.
spacing between status chip and info was too big. I tested and this change doesn't affect the old playground.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Each environment in the diff table has info icon with the execution plan
This component is already tested and since we're not adding any if statements I am not adding new tests.
Important files
Discussion points