Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add admin guard to groups #4069

Merged
merged 1 commit into from
Jun 22, 2023
Merged

fix: add admin guard to groups #4069

merged 1 commit into from
Jun 22, 2023

Conversation

nunogois
Copy link
Member

Adds an admin guard to groups: It is an admin feature and should be guarded on the UI the same way other admin features are.

@vercel
Copy link

vercel bot commented Jun 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview Jun 22, 2023 2:11pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Jun 22, 2023 2:11pm

Copy link
Contributor

@gastonfournier gastonfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If only the admin can add groups, this LGTM!

@nunogois nunogois merged commit 40a4451 into main Jun 22, 2023
19 checks passed
@nunogois nunogois deleted the fix-groups-admin-guard branch June 22, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants