fix: add strategy bug when strategySplittedButton flag is on #4071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kwasniew
approved these changes
Jun 23, 2023
| @@ -101,11 +101,24 @@ export const FeatureStrategyCreate = () => { | |||
|
|
|||
| useEffect(() => { | |||
| if (shouldUseDefaultStrategy) { | |||
| setStrategy((defaultStrategy as any) || DEFAULT_STRATEGY); | |||
| const strategyTemplate = defaultStrategy || DEFAULT_STRATEGY; | |||
| if ( | |||
There was a problem hiding this comment.
Can be simplified to
if (strategyTemplate.parameters?.groupId === '' && featureId) {
strategyTemplate.parameters.groupId = featureId;
}
| ) { | ||
| strategyTemplate.parameters.groupId = featureId; | ||
| } | ||
| setStrategy(strategyTemplate as any); |
There was a problem hiding this comment.
as any can be avoided by changing
export interface IFeatureStrategy {
...other fields
title?: string | null;
disabled?: boolean | null;
}
Our FE code didn't match openapi schema so let's adjust them instead of ignorign types
There was a problem hiding this comment.
I added nullable constraint ont itle and disabled as indicated by the openapi schema
There was a problem hiding this comment.
Turns out doing the type change opens a huge can of worms. I think more important to fix the functionality. Decided to skip this for now
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 2 bugs after the recent strategy improvements v2 changes:
When creating a strategy the
groupIdparam of the Gradual Rollout strategy now populates the groupId (when using default strategy, the groupId will only be overwritten when it is an empty string ) with the feature name (as it was before)When editing/setting a default strategy for an environment the
groupIdparam should be an empty string, but editable.About the changes
Closes #
Important files
Discussion points