feat: upgrade AdminAlert to PermissionGuard #4074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
gastonfournier
approved these changes
Jun 22, 2023
There was a problem hiding this comment.
I think this helps to explain to the user what type of permission they need, but I'm not sure this is what we want to do. Most services don't provide many details about which permissions you're missing. I think it's a good feature but I'd validate it with others
chriswk
approved these changes
Jun 23, 2023
There was a problem hiding this comment.
I concur with Gaston here. I really like this feature, it might even help people request the correct access from their manager / admin.
Ping @thomasheartman - What do you think?
nunogois
force-pushed
the
feat-permission-guard
branch
from
d052ecb
to
5a07e46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/unleash/issue/2-1165/improve-adminalert-usage-to-be-more-generic-accept-non-admin
Upgrades our
AdminAlertto a newPermissionGuard.Question: We don't need to, but should we be specific about the
ADMINpermission every time?Technically
PermissionGuardcould havepermissionsas optional and assume[]by default, which will addADMINanyways. However, I feel like we may gain some readability if we're specific about it. WDYT?Single permission:
Multiple permissions:
