fix: remove playground results flip #4076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
kwasniew
commented
Jun 23, 2023
| @@ -57,6 +57,7 @@ export const AdvancedPlayground: VFC<{ | |||
| const [searchParams, setSearchParams] = useSearchParams(); | |||
| const searchParamsLength = Array.from(searchParams.entries()).length; | |||
| const { evaluateAdvancedPlayground, loading } = usePlaygroundApi(); | |||
| const [hasFormBeenSubmitted, setHasFormBeenSubmitted] = useState(false); | |||
There was a problem hiding this comment.
new variable to store if form was submitted
kwasniew
commented
Jun 23, 2023
| <ConditionallyRender | ||
| condition={ | ||
| !Boolean(results) && | ||
| !hasFormBeenSubmitted |
There was a problem hiding this comment.
this removing flipping effect
thomasheartman
approved these changes
Jun 23, 2023
There was a problem hiding this comment.
This looks good to me! My only question would be if we could use data state to check whether the form has been submitted or not instead of introducing a new state variable, but I'm assuming you've already explored that possibility? But definitely non-blocking. Nice work! 🏆
|
@thomasheartman You're right. I tried to do it w/o a new state variable but couldn't get it to work as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Before:
After:
Important files
Discussion points