feat: count number of combinations from playground #4077
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
| @@ -0,0 +1,12 @@ | |||
| import { AdvancedPlaygroundFeatureSchema } from 'openapi'; | |||
|
|
|||
| export const countCombinations = ( | |||
There was a problem hiding this comment.
Maybe backend should return it?
There was a problem hiding this comment.
(For future visibility; as mentioned in the slack discussion)
That's a good point! I put it in the frontend for now because that’s where we track events. Seemed sensible to do the calculations as close to where we track them as possible instead of sending them over the wire. That said, we could update the advanced playground response schema to include the count instead, but this seems like it would incur more complexity. I think the best reason for not doing it in the frontend is to reduce the amount of computation client side (and the bundle size, I suppose). That might be a worthwhile tradeoff, but how about we see whether it causes any performance problems first?
This PR adds plausible tracking of the number of feature combinations that we get from the advanced playground API.
The event type has been added to plausible
Relates to #3545