refactor: use requestType instead of isAdmin, optionalIncludes
#4115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the burden of knowing what optionalIncludes is and also prevents weird edge cases like isAdmin with optionalIncludes.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
kwasniew
approved these changes
Jul 4, 2023
|
Had a feeling you'd like this one 😄 And yeah, good point! I'll double check! |
|
The Rust SDK (which we know is a little finicky) runs fine with these changes, as does the Go SDK, so I'm happy to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the burden of knowing what optionalIncludes is and also
prevents weird edge cases like isAdmin with optionalIncludes.