Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openapi: strategies tag #4116

Merged
merged 11 commits into from
Jul 4, 2023
Merged

openapi: strategies tag #4116

merged 11 commits into from
Jul 4, 2023

Conversation

thomasheartman
Copy link
Contributor

@thomasheartman thomasheartman commented Jun 29, 2023 •
edited

Update OpenAPI schemas and operation descriptions for the strategies tag.

@vercel
Copy link

vercel bot commented Jun 29, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 4, 2023 8:01am
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 4, 2023 8:01am

@thomasheartman thomasheartman marked this pull request as draft June 29, 2023 08:59
@thomasheartman thomasheartman marked this pull request as ready for review June 30, 2023 11:50
sjaanus
sjaanus reviewed Jul 4, 2023
View reviewed changes
Copy link
Contributor

@sjaanus sjaanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Context and staregies controller should respondWithValidation. This will allow our e2e tests to validate schema.

Or we need to skip validation to send extra headers?

@thomasheartman
Copy link
Contributor Author

Ah, great! I hadn't thought about that. I'm happy to put that in, for sure.

Or we need to skip validation to send extra headers?

I'm not sure exactly what you mean here? I don't think we need to skip validation, though.

@thomasheartman
Copy link
Contributor Author

Should be addressed in 6c6251f now. I'm assuming we don't use respondWithValidation for responses without bodies, right?

@sjaanus
Copy link
Contributor

sjaanus commented Jul 4, 2023

Should be addressed in 6c6251f now. I'm assuming we don't use respondWithValidation for responses without bodies, right?

Yes, we dont use it for responses without bodies.

@thomasheartman thomasheartman merged commit f799f72 into main Jul 4, 2023
17 checks passed
@thomasheartman thomasheartman deleted the openapi/strategies-tag branch July 4, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjaanus sjaanus sjaanus approved these changes

Assignees

@thomasheartman thomasheartman

Labels
None yet
Projects
Issues and PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thomasheartman @sjaanus